-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Python 3.11 upgrade #41
Enhancement: Python 3.11 upgrade #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. I am constantly getting Socket timeout
during nodejs-requirements layer. I will retry later. Once verified, I will give 👍🏽
Should we not update these details here tutor-credentials/tutorcredentials/templates/credentials/build/credentials/Dockerfile Line 4 in ad4d593
as per this commit? |
|
as the maintainer's and author's information already mentioned in the setup.py
As the upstream credentials repo seems to be breaking on arm64 and they are skipping arm64 builds as well due to the didkit package dependency not available on arm64 yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not re-tried it but going to give a 👍🏽 as I understand Danyal has been testing it out.
Please use "Squash and Merge" when merging this. Thanks
close #34
NOTES: