Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ANDROID_APP_VERSION to be dynamic based on OPENEDX_COMMON_VERSION #23

Merged

Conversation

hamza-56
Copy link
Contributor

@hamza-56 hamza-56 commented Jun 10, 2024

This PR updates the logic for setting the ANDROID_APP_VERSION in the Dockerfile. The new logic uses a conditional statement to determine the value based on the OPENEDX_COMMON_VERSION variable.

For the nightly build, set ANDROID_APP_VERSION to main.
For master and redwood branches, set ANDROID_APP_VERSION to the value of OPENEDX_COMMON_VERSION.

regisb
regisb previously requested changes Jun 10, 2024
Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be made to the master branch, not the nightly branch. Also, please add a changelog entry: https://docs.tutor.overhang.io/tutor.html#contributing

EDIT: it's OK to merge in nightly, as long as the redwood branch is rebased on top of nightly.

@DawoudSheraz
Copy link
Contributor

This change should be made to the master branch, not the nightly branch. Also, please add a changelog entry: https://docs.tutor.overhang.io/tutor.html#contributing

This is for the new android app, and those initial changes were merged to nightly.

@regisb regisb dismissed their stale review June 10, 2024 14:16

My comment was not relevant.

@hamza-56 hamza-56 requested a review from regisb June 10, 2024 16:53
Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@regisb regisb merged commit 5f10cfe into overhangio:nightly Jun 11, 2024
@regisb regisb deleted the feature/dynamic-android-app-version branch June 11, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants