feat(addCommand): longString #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thelindat
reviewed
Jun 26, 2024
imports/addCommand/server.lua
Outdated
Comment on lines
48
to
56
| elseif param.type == 'longString' and i == paramsNum then | ||
| value = arg | ||
|
|
||
| local argsNum = #args | ||
| if paramsNum < argsNum then | ||
| for a = i + 1, argsNum do | ||
| value = value .. ' ' .. args[a] | ||
| end | ||
| end |
There was a problem hiding this comment.
Rather than concatenating the rest of the passed arguments, just take the raw string and trim off the other arguments. Same for the ts version.
There was a problem hiding this comment.
Ah yeah I forgot we had a raw string
|
Raw string now used |
|
To clarify, there's no need to split the string into many parts and concatenate or join strings together. Just get the position of the last argument in the raw string and then make a substring from that point. |
|
Changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever you have a command that has a text type at the end where you want to catch all text from that argument and on, only the first word will be assigned to that argument and the rest ends up all in an array which makes for a mixed table. With longString it catches those extras if the argument is at the end of the given params.
For example
/test test1 test2Before only
test1would be shown.After, all text will be shown.
I haven't tested this yet but ChatGPT said it will work fine