fix(lib.waitFor): Improved Timeout Calculation and Error Message Formatting #518
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes some minor fixess to the
lib.waitFor
function. The changes aim to improve accuracy in handling timeout calculations and error message formatting.Changes Made
Removed the redundant if condition checking fortimeout
truthiness or nil value.Previous Behaviour
lib.waitFor
function with timeout value of 1000:Current Behaviour (Following the fix)
lib.waitFor
function with timeout value of 1000:lib.waitFor
function now correctly displays the error message with the accurate timeout in milliseconds. Additionally, the function now consistently times out after the correct duration.