Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(addKeybind): support others defaultMapper #219

Merged
merged 1 commit into from
Apr 17, 2023
Merged

feat(addKeybind): support others defaultMapper #219

merged 1 commit into from
Apr 17, 2023

Conversation

dolutattoo
Copy link
Contributor

@dolutattoo dolutattoo commented Feb 7, 2023

Usefull to be able to register other inputs such as MOUSE_BUTTON
Will break current people stuff tho

@thelindat
Copy link
Member

Will break current people stuff tho

Why would this break?

Aside from that would be good to either set the valid mappers ('keyboard' | 'mouse_button' etc.) or at least link the relevant fivem docs.

@Scullyy
Copy link
Contributor

Scullyy commented Feb 27, 2023

Will break current people stuff tho

Why would this break?

Aside from that would be good to either set the valid mappers ('keyboard' | 'mouse_button' etc.) or at least link the relevant fivem docs.

Doesn't look like it would, backwards compatibility was added

if not data.defaultMapper then data.defaultMapper = 'keyboard' end

@dolutattoo dolutattoo closed this Mar 2, 2023
@dolutattoo
Copy link
Contributor Author

I think it is a bit too much to add all options so I put the link instead

'DIGITALBUTTON_AXIS' | 'GAME_CONTROLLED' | 'JOYSTICK_AXIS' | 'JOYSTICK_AXIS_NEGATIVE' | 'JOYSTICK_AXIS_POSITIVE' | 'JOYSTICK_BUTTON' | 'JOYSTICK_IAXIS' | 'JOYSTICK_POV' | 'JOYSTICK_POV_AXIS' | 'KEYBOARD' | 'MKB_AXIS' | 'MOUSE_ABSOLUTEAXIS' | 'MOUSE_BUTTON' | 'MOUSE_BUTTONANY' | 'MOUSE_CENTEREDAXIS' | 'MOUSE_RELATIVEAXIS' | 'MOUSE_SCALEDAXIS' | 'MOUSE_NORMALIZED' | 'MOUSE_WHEEL' | 'PAD_ANALOGBUTTON' | 'PAD_AXIS' | 'PAD_DEBUGBUTTON' | 'PAD_DIGITALBUTTON' | 'PAD_DIGITALBUTTONANY' | 'TOUCHPAD_ABSOLUTE_AXIS' | 'TOUCHPAD_CENTERED_AXIS'

@dolutattoo dolutattoo reopened this Mar 2, 2023
@thelindat thelindat merged commit b035c5a into overextended:master Apr 17, 2023
@dolutattoo dolutattoo deleted the feat/addKeybind-defaultMapper branch July 27, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants