fix/feat(progressbar): Better animation cancelling #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Stops setting the data.anim to a boolean value because we aren't using the same if statement for cancelling the tasks - If animation then it will cancel only the animation played by the progress bar - If scenario then it will clear ped tasks like before This should make it so people can do things like eat sitting down and after a progress bar animation it won't make you stand up.
| @@ -143,6 +135,13 @@ local function startProgress(data) | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| if data.anim then | |||
There was a problem hiding this comment.
The if should check for data.anim?.dict and possibly for data.anim?.clip instead
The elseif also should check for data.anim?.scenario
thelindat
added a commit
that referenced
this pull request
Feb 3, 2023
Correct behaviour from pull request #208. Include some refactoring to reduce repetitive table indexing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This should make it so people can do things like eat sitting down and after a progress bar animation it won't make you stand up.