Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Field types for V3 (Time and Radio Buttons) #206

Merged
merged 4 commits into from
Jan 31, 2023
Merged

New Field types for V3 (Time and Radio Buttons) #206

merged 4 commits into from
Jan 31, 2023

Conversation

masonschafercodes
Copy link
Contributor

@masonschafercodes masonschafercodes commented Jan 22, 2023 •
edited
Loading

Don't know if this is necessarily wanted in v3, but I added it just to have more options on the date / time input

Edit:

Adding radio buttons here as well

@masonschafercodes masonschafercodes changed the title feat(web/input): time input New Field types for V3 (Time and Radio Buttons) Jan 22, 2023
@LukeWasTakenn LukeWasTakenn self-assigned this Jan 26, 2023
LukeWasTakenn
LukeWasTakenn requested changes Jan 30, 2023
View reviewed changes
Copy link
Member

@LukeWasTakenn LukeWasTakenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time LGTM, but not going to be adding radio buttons so if you could force push it out of existence into another universe that would be nice!

@masonschafercodes
Copy link
Contributor Author

I will get this updated after work.

@masonschafercodes
Copy link
Contributor Author

Decided that work is a fantasy... changes have been made and should be all good to go

LukeWasTakenn
LukeWasTakenn reviewed Jan 31, 2023
View reviewed changes
Copy link
Member

@LukeWasTakenn LukeWasTakenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, but since this returns a unix timestamp I'm assuming there's a date attached to it as well, is the date always the same or?

@LukeWasTakenn
Copy link
Member

LGTM overall, but since this returns a unix timestamp I'm assuming there's a date attached to it as well, is the date always the same or?

Oh it seems to return the current date with the input time

@LukeWasTakenn LukeWasTakenn merged commit 8a7e0f8 into overextended:v3 Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukeWasTakenn LukeWasTakenn LukeWasTakenn approved these changes

Assignees

@LukeWasTakenn LukeWasTakenn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masonschafercodes @LukeWasTakenn