Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(interface/dialog): readonly, disabled flags #142

Merged
merged 3 commits into from
Oct 27, 2022
Merged

feat(interface/dialog): readonly, disabled flags #142

merged 3 commits into from
Oct 27, 2022

Conversation

davidxd33
Copy link
Contributor

This adds support for making fields disabled or read only.

@davidxd33 davidxd33 mentioned this pull request Oct 26, 2022
Closed
@LukeWasTakenn
Copy link
Member

Are readonly and disabled not kind of the same thing?

@davidxd33
Copy link
Contributor Author

Are readonly and disabled not kind of the same thing?

One greys it out and changes the cursor, the other just makes it "uninteractable" while looking normal.

LukeWasTakenn
LukeWasTakenn requested changes Oct 26, 2022
View reviewed changes
Copy link
Member

@LukeWasTakenn LukeWasTakenn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TS types in the package should also be updated, and could you also make a PR to the docs?

@davidxd33
Copy link
Contributor Author

The TS types in the package should also be updated, and could you also make a PR to the docs?

Done

LukeWasTakenn
LukeWasTakenn approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@LukeWasTakenn LukeWasTakenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed read only property because I can already see people complaining that it's not working even though it's the intended behavior.

@LukeWasTakenn LukeWasTakenn merged commit 4f69c7c into overextended:master Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukeWasTakenn LukeWasTakenn LukeWasTakenn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidxd33 @LukeWasTakenn