-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolver: fix debug mode crash in test/bundler/bun-build-api.test.ts #9140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @paperdave |
❌ @nektro 1 files with test failures on bun-darwin-aarch64: |
❌ @nektro 1 files with test failures on linux-x64-baseline:
|
❌ @nektro 2 files with test failures on linux-x64:
|
❌🪟 @nektro, there are 43 test regressions on Windows x86_64
|
nikeee
pushed a commit
to nikeee/bun
that referenced
this pull request
Feb 28, 2024
Jarred-Sumner
added a commit
that referenced
this pull request
Feb 28, 2024
…trailing slash" (#9144) * okaaaaaaaay * Revert "resolver: fix debug mode crash in test/bundler/bun-build-api.test.ts (#9140)" This reverts commit 331d079. * correctly fix the cache bust bug this was introduced a couple of commits ago in my random fixes, where i put the wrong fix to another directory caching bug. i still stand by the assertion in place despite it causing many people issues. it's precense will prevent subtle module resolutions failures. * add an extra comment * fix building a release build locally * add a better test case for 3216 * staging * fix mac issues * ok --------- Co-authored-by: Jarred Sumner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
path being processed here is normalized here
bun/src/bun.js/javascript.zig
Lines 1717 to 1741 in bf3dbda
/
even on windows