-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support test.fixme
, test.fixmeIf
, and test.todoIf
#9044
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ @Electroid 7 files with test failures on bun-darwin-aarch64:
|
❌ @Electroid 6 files with test failures on linux-x64:
|
❌ @Electroid 7 files with test failures on linux-x64-baseline:
|
❌🪟 @Electroid, there are 36 test regressions on Windows x86_64
|
❌ @Electroid 5 files with test failures on bun-darwin-x64:
|
Per IRL discussion, I don't think we should do this. Maybe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds the same API as playwright's
test.fixme()
to the test runner. This allows developers to mark a test as flaky or broken, but does not fail the overall test suite.We will use this internally to get our Github CI to green so we can turn on the merge queue. Others may find it useful.
How did you verify your code works?
I wrote automated tests