Does not fix #4622 #5452
Merged
Does not fix #4622 #5452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paperdave
pushed a commit
to SuperAuguste/bun
that referenced
this pull request
Sep 18, 2023
* Fixes oven-sh#4622 * cleanup --------- Co-authored-by: Jarred Sumner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Does not fix #4622, but gets closer
serialport no longer crashes
Don't know if
serialportactually works thoughEdit: serialport relies on libuv symbols which bun does not currently implement. This PR is still some good bugfixes for napi. But it does not fix the issue serialport is running into.
These are missing: