Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs - Add "workspace:*" to workspace docs. #5379

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

dylang
Copy link
Contributor

@dylang dylang commented Sep 14, 2023

What does this PR do?

Explain that the version of packages within a workspace need to be "workspace:*".

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

@colinhacks colinhacks merged commit f3fe450 into oven-sh:main Sep 14, 2023
1 check passed
@colinhacks
Copy link
Contributor

Thanks!

"name": "pkg-a",
"version": "1.0.0",
"dependencies": {
"pkg-b": "workspace:*"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we avoid this workspace:* ?

Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner Sep 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, you can put "pkg-b": "*" too

paperdave pushed a commit to SuperAuguste/bun that referenced this pull request Sep 18, 2023
* add workspace:* to docs

* Updates

---------

Co-authored-by: Colin McDonnell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants