Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules documentation didn't have correct import example #5225

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

miccou
Copy link
Contributor

@miccou miccou commented Sep 13, 2023

What does this PR do?

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

I noticed that the modules documentation doesn't include import example code in the imports section.

image

This PR replaces the screenshotted code block with:

import { foo } from "./foo"; // extensions are optional
import bar from "./bar.ts";
import { stuff } from "./my-commonjs.cjs";

@colinhacks colinhacks merged commit cf83496 into oven-sh:main Sep 14, 2023
@colinhacks
Copy link
Contributor

Oops. Thanks!

paperdave pushed a commit to SuperAuguste/bun that referenced this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants