Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime): make most globals configurable/deletable, allow resuming the console iterator #5216

Merged
merged 10 commits into from
Sep 14, 2023

Conversation

paperdave
Copy link
Member

What does this PR do?

fixes #4806
fixes #2269
fixes #399

things tagged on here as well

.

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

I wrote automated tests

@paperdave paperdave force-pushed the dave/deletable-globals branch 2 times, most recently from 4a94273 to ec318f6 Compare September 14, 2023 00:45
@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

✅ test failures on linux-x64 have been resolved.

#b3f11f4fc864333e9959fa1470035de1b2c3a8b3

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

@paperdave 1 files with test failures on linux-x64-baseline:

  • test/js/node/async_hooks/AsyncLocalStorage.test.ts

View test output

#b3f11f4fc864333e9959fa1470035de1b2c3a8b3

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

@paperdave 7 files with test failures on bun-darwin-x64-baseline:

  • test/cli/install/bun-install.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/node/fs/fs.test.ts
  • test/js/node/watch/fs.watchFile.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#b3f11f4fc864333e9959fa1470035de1b2c3a8b3

@Jarred-Sumner Jarred-Sumner merged commit 9976e3f into main Sep 14, 2023
12 checks passed
@Jarred-Sumner Jarred-Sumner deleted the dave/deletable-globals branch September 14, 2023 04:39
paperdave added a commit to SuperAuguste/bun that referenced this pull request Sep 18, 2023
…g the console iterator (oven-sh#5216)

* Fix oven-sh#5177

* Fix oven-sh#5175

* make most globals deletable/overridable

* not done

* cool

* a

* done

* fix test

* oops

* yippee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants