-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(runtime): make most globals configurable/deletable, allow resuming the console iterator #5216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paperdave
force-pushed
the
dave/deletable-globals
branch
2 times, most recently
from
September 14, 2023 00:45
4a94273
to
ec318f6
Compare
✅ test failures on linux-x64 have been resolved. |
❌ @paperdave 1 files with test failures on linux-x64-baseline:
|
❌ @paperdave 7 files with test failures on bun-darwin-x64-baseline:
|
paperdave
force-pushed
the
dave/deletable-globals
branch
from
September 14, 2023 04:35
ec318f6
to
ba1a649
Compare
paperdave
added a commit
to SuperAuguste/bun
that referenced
this pull request
Sep 18, 2023
…g the console iterator (oven-sh#5216) * Fix oven-sh#5177 * Fix oven-sh#5175 * make most globals deletable/overridable * not done * cool * a * done * fix test * oops * yippee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fixes #4806
fixes #2269
fixes #399
things tagged on here as well
constants
stringasyncIterator
Closesfor await
from console only works once #5175.
How did you verify your code works?
I wrote automated tests