fix(node:dns): fix crash and compatibility issues with resolve
#5200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
1. long string could lead to a segfault.
Segmentfault code:
null
should not be used here as it can lead to a crash. (Line 530)bun/src/deps/c_ares.zig
Lines 526 to 541 in 3b2c094
2. Fix a compatibility issue (
resolveNs
andresolveSoa
)bun doesn't allow empty strings to be passed into these two functions.
How did you verify your code works?
I wrote automated tests
make js
and committed the transpiled changesbun fmt
)zig fmt
on the changed files