Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix lifecycle docu #5159

Merged
merged 1 commit into from
Sep 13, 2023
Merged

fix lifecycle docu #5159

merged 1 commit into from
Sep 13, 2023

Conversation

ximex
Copy link
Contributor

@ximex ximex commented Sep 12, 2023

What does this PR do?

fix code example in documentation about lifecycle hooks

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

didn't tested it but seems logic

Electroid
Electroid approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@Electroid Electroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Electroid Electroid merged commit 8777c3f into oven-sh:main Sep 13, 2023
@ximex ximex deleted the patch-1 branch September 13, 2023 05:37
paperdave pushed a commit to SuperAuguste/bun that referenced this pull request Sep 18, 2023
@ximex @paperdave
fix lifecycle docu (oven-sh#5159)
33e69be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Electroid Electroid Electroid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ximex @Electroid