-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to latest Zig #1610
Upgrade to latest Zig #1610
Conversation
Just FYI From: https://ziglang.org/news/goodbye-cpp/
Zig 0.11.0 Github milestone = https://github.com/ziglang/zig/milestone/17
|
https://discord.com/channels/605571803288698900/785499283368706060/1053028467517698048 |
Rebased against Once ziglang/zig#14004 is merged, I'll give it another try |
Current status: stuck on a confusing compiler error. It seems to think that a function that doesn't use error: expected error union type, found '?*bun.js.javascript_core_c_api.generic'
return js.JSValueMakeUndefined(ctx);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
referenced by:
readFileAsBytes: src/bun.js/api/bun.zig:801:20
Class: src/bun.js/api/bun.zig:1129:23
remaining reference traces hidden; use '-freference-trace' to see all reference traces
/home/jarred/zig/0.11.0-dev.926+266e2e9a3/files/lib/std/mem.zig:3644:9: error: expected []T or *[_]T, passed error{OutOfMemory}![]i32
@compileError("expected []T or *[_]T, passed " ++ @typeName(sliceType));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/jarred/zig/0.11.0-dev.926+266e2e9a3/files/lib/std/mem.zig:3651:59: note: called from here
pub fn sliceAsBytes(slice: anytype) SliceAsBytesReturnType(@TypeOf(slice)) { |
This is blocked on ziglang/zig#13017.
Posting this PR here so others can follow progress