New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spawnSync shouldn't throw #15561

Merged

Jarred-Sumner merged 2 commits into main from jarred/exit

Dec 4, 2024

Collaborator

Jarred-Sumner commented Dec 4, 2024

What does this PR do?

spawnSync shouldn't throw

How did you verify your code works?

this needs a test.


          spawnSync shouldn't throw

a7bccd8

robobun commented Dec 4, 2024 •

edited

Loading

❌ @nektro, your commit a8da9ea has 10 failures in #7247:

test/regression/issue/09041.test.ts - 1 failing on 🐧 3.20 x64

test/js/node/test/parallel/worker-nested-uncaught.test.js - segmentation fault on 🐧 3.20 x64

test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 3.20 x64

test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 3.20 x64-baseline

test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 aarch64

test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 12 x64

test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 22.04 x64-baseline

test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 22.04 x64

test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 x64

test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 x64-baseline

test/v8/v8.test.ts - 22 failing on 🐧 3.20 aarch64

test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64

test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64-baseline

test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 22.04 x64-baseline

test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 aarch64

test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 x64

test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 x64-baseline

test/js/bun/http/serve.test.ts - SIGTRAP on 🐧 3.20 aarch64

test/js/bun/http/serve.test.ts - SIGILL on 🐧 3.20 x64

test/js/bun/http/serve.test.ts - SIGILL on 🐧 3.20 x64-baseline

test/bake/dev/bundle.test.ts - 1 failing on 🐧 22.04 x64-baseline

test/cli/hot/hot.test.ts - timeout on 🐧 22.04 aarch64

test/cli/hot/hot.test.ts - 2 failing on 🐧 3.20 x64-baseline

Member

nektro commented Dec 4, 2024

this fixes at least 36 node tests, i'll commit a test of our own


          add test

a8da9ea

nektro marked this pull request as ready for review

December 4, 2024 03:15

Jarred-Sumner merged commit 0d5e4e1 into main

65 of 67 checks passed

Jarred-Sumner deleted the jarred/exit branch

December 4, 2024 03:26

nektro mentioned this pull request

spawnSync throws error instead of defining property #8729

Closed

DonIsaac pushed a commit that referenced this pull request


          spawnSync shouldn't throw (#15561)

77ce7e9

Co-authored-by: Meghan Denny <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet