Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Connect with 1 socket to new env var but still work with js debug terminal #15458

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

alii
Copy link
Collaborator

@alii alii commented Nov 28, 2024

What does this PR do?

Fixes the connection by using a new environment variable, so the logic stays the same from previous versions of bun with BUN_INSPECT and _NOTIFY

How did you verify your code works?

Test with bun 1.1.37, as well as a local release build in both the normal terminal and the debug terminal.

It's possible I've missed a case for testing here, and in an effort to not have another botched release, it would be great if someone else could test this as well locally.

@robobun
Copy link

robobun commented Nov 28, 2024

@alii, your commit aa46c29 has 13 failures in #7043:

  • test/integration/next-pages/test/next-build.test.ts - 1 failing on 🍎 14 x64
  • test/regression/issue/09041.test.ts - 1 failing on 🐧 3.20 x64
  • test/js/node/test/parallel/worker-nested-uncaught.test.js - segmentation fault on 🐧 3.20 x64-baseline
  • test/js/node/test/parallel/worker-nested-uncaught.test.js - segmentation fault on 🐧 3.20 x64
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 3.20 x64
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 aarch64
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 x64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 aarch64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64-baseline
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 22.04 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 11 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 aarch64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 22.04 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 x64
  • test/cli/hot/hot.test.ts - timeout on 🐧 22.04 x64-baseline
  • test/cli/hot/hot.test.ts - timeout on 🐧 3.20 aarch64
  • test/js/bun/http/serve.test.ts - SIGTRAP on 🐧 3.20 aarch64
  • test/js/bun/http/serve.test.ts - SIGILL on 🐧 3.20 x64-baseline
  • test/js/bun/http/serve.test.ts - SIGILL on 🐧 3.20 x64
  • test/bundler/bundler_compile.test.ts - 1 failing on 🐧 12 x64-baseline
  • test/js/web/fetch/fetch-leak.test.ts - 1 failing on 🪟 2019 x64
  • test/regression/issue/ctrl-c.test.ts - 1 failing on 🍎 14 aarch64
  • test/cli/run/require-cache.test.ts - 1 failing on 🪟 2019 x64-baseline
  • @Jarred-Sumner Jarred-Sumner merged commit 08222ed into main Nov 28, 2024
    66 of 67 checks passed
    @Jarred-Sumner Jarred-Sumner deleted the ali-fix-extension-env-var branch November 28, 2024 04:47
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants