Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zig: make throw use JSError #15444

Merged
merged 6 commits into from
Dec 2, 2024
Merged

zig: make throw use JSError #15444

merged 6 commits into from
Dec 2, 2024

Conversation

nektro
Copy link
Member

@nektro nektro commented Nov 27, 2024

progress towards #15141

@robobun
Copy link

robobun commented Nov 27, 2024

@nektro, your commit 407b0d7 has 14 failures in #7163:

  • test/js/bun/http/bun-serve-static.test.ts - timeout on 🐧 3.20 x64-baseline
  • test/regression/issue/09041.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/js/node/test/parallel/worker-nested-uncaught.test.js - segmentation fault on 🐧 3.20 x64-baseline
  • test/js/node/test/parallel/worker-nested-uncaught.test.js - segmentation fault on 🐧 3.20 x64
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 3.20 x64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 aarch64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64-baseline
  • test/js/node/util/test-aborted.test.ts - 1 failing on 🐧 20.04 x64-baseline
  • test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 11 x64-baseline
  • test/cli/install/registry/bun-install-registry.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 aarch64
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 x64
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/js/bun/http/serve.test.ts - SIGTRAP on 🐧 3.20 aarch64
  • test/js/bun/http/serve.test.ts - SIGILL on 🐧 3.20 x64
  • test/js/bun/http/serve.test.ts - SIGILL on 🐧 3.20 x64-baseline
  • test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 22.04 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 12 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 22.04 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 22.04 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 aarch64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 x64-baseline
  • test/js/bun/util/filesink.test.ts - 1 failing on 🐧 22.04 aarch64
  • test/cli/hot/hot.test.ts - timeout on 🐧 22.04 aarch64
  • test/cli/hot/hot.test.ts - timeout on 🐧 11 x64-baseline
  • test/cli/hot/hot.test.ts - timeout on 🐧 22.04 x64
  • test/cli/hot/hot.test.ts - timeout on 🐧 3.20 x64
  • test/cli/hot/hot.test.ts - timeout on 🐧 3.20 x64-baseline
  • test/bake/dev/esm.test.ts - 1 failing on 🐧 22.04 aarch64
  • @Jarred-Sumner
    Copy link
    Collaborator

    Per IRL discussion, this should be done via bindings generator instead of manually changing each call site to use try

    @Jarred-Sumner
    Copy link
    Collaborator

    Jarred-Sumner commented Nov 27, 2024

    Jsut the ones involving .get() and the like should be done via bindings generator

    @nektro nektro marked this pull request as ready for review November 27, 2024 09:08
    @nektro nektro requested a review from paperdave December 2, 2024 21:01
    @nektro nektro merged commit 2d441d8 into main Dec 2, 2024
    66 of 67 checks passed
    @nektro nektro deleted the nektro-patch-37757 branch December 2, 2024 22:19
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants