Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zig: make throwInvalidArgumentTypeValue use JSError #15302

Merged
merged 5 commits into from
Nov 27, 2024
Merged

Conversation

nektro
Copy link
Member

@nektro nektro commented Nov 21, 2024

progress towards #15141

@robobun
Copy link

robobun commented Nov 21, 2024

@nektro, your commit 29d3ea7 has 16 failures in #6952:

  • test/js/node/test/parallel/worker-nested-uncaught.test.js - segmentation fault on 🐧 3.20 x64-baseline
  • test/js/node/test/parallel/worker-nested-uncaught.test.js - segmentation fault on 🐧 3.20 x64
  • test/js/bun/http/bun-serve-static.test.ts - timeout on 🐧 3.20 x64
  • test/js/bun/http/bun-serve-static.test.ts - timeout on 🐧 3.20 x64-baseline
  • test/regression/issue/ctrl-c.test.ts - 1 failing on 🍎 14 aarch64
  • test/js/web/fetch/fetch.test.ts - 4 failing on 🍎 14 aarch64
  • test/js/web/fetch/fetch.test.ts - 5 failing on 🍎 13 aarch64
  • test/js/web/fetch/fetch.test.ts - 4 failing on 🍎 13 x64
  • test/js/web/fetch/fetch.test.ts - 4 failing on 🍎 14 x64
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 3.20 x64
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/cli/install/bun-run.test.ts - 1 failing on 🐧 3.20 x64
  • test/js/node/watch/fs.watch.test.ts - 2 failing on 🍎 14 aarch64
  • test/js/node/watch/fs.watch.test.ts - 2 failing on 🍎 13 aarch64
  • test/js/node/watch/fs.watch.test.ts - 2 failing on 🍎 13 x64
  • test/js/node/watch/fs.watch.test.ts - 2 failing on 🍎 14 x64
  • test/js/node/test/parallel/fs-mkdir-recursive-eaccess.test.js - 2 failing on 🍎 14 aarch64
  • test/js/node/test/parallel/fs-mkdir-recursive-eaccess.test.js - 2 failing on 🍎 13 aarch64
  • test/js/node/test/parallel/fs-mkdir-recursive-eaccess.test.js - 2 failing on 🍎 13 x64
  • test/js/node/test/parallel/fs-mkdir-recursive-eaccess.test.js - 2 failing on 🍎 14 x64
  • test/regression/issue/09041.test.ts - 1 failing on 🐧 12 x64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 aarch64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64-baseline
  • test/cli/hot/hot.test.ts - timeout on 🐧 3.20 aarch64
  • test/cli/hot/hot.test.ts - timeout on 🐧 3.20 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 22.04 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 12 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 11 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 22.04 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 aarch64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 x64
  • test/js/bun/http/serve.test.ts - segmentation fault on 🐧 3.20 aarch64
  • test/js/bun/http/serve.test.ts - segmentation fault on 🐧 3.20 x64
  • test/js/bun/http/serve.test.ts - segmentation fault on 🐧 3.20 x64-baseline
  • test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 22.04 aarch64
  • test/js/web/timers/setInterval.test.js - 1 failing on 🪟 2019 x64
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🪟 2019 x64-baseline
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 aarch64
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 x64
  • @nektro nektro marked this pull request as ready for review November 21, 2024 03:25
    Copy link
    Collaborator

    @Jarred-Sumner Jarred-Sumner left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    We cannot merge this without tests that verify these bindings work.

    Copy link
    Member

    @cirospaciari cirospaciari left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Need update before merging
    Screenshot 2024-11-26 at 15 00 31

    @nektro
    Copy link
    Member Author

    nektro commented Nov 27, 2024

    binding tests were added and fixed in #15362, then pulled in during an earlier main merge

    @nektro nektro merged commit 215fdb4 into main Nov 27, 2024
    65 of 67 checks passed
    @nektro nektro deleted the nektro-patch-41933 branch November 27, 2024 01:17
    snoglobe pushed a commit that referenced this pull request Dec 4, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants