zig: make JSValue.toBunString use JSError #15295
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarred-Sumner
requested changes
Nov 23, 2024
paperdave
requested changes
Nov 26, 2024
| @@ -1106,7 +1106,7 @@ pub const JestPrettyFormat = struct { | |||
| defer message_string.deref(); | |||
|
|
|||
| if (value.fastGet(this.globalThis, .message)) |message_prop| { | |||
| message_string = message_prop.toBunString(this.globalThis); | |||
| message_string = message_prop.toBunString(this.globalThis) catch bun.String.static("(threw exception creating message)"); | |||
There was a problem hiding this comment.
should this exception be cleared?
| @@ -328,7 +326,7 @@ pub const WebWorker = struct { | |||
| var vm = this.vm orelse return; | |||
| if (vm.log.msgs.items.len == 0) return; | |||
| const err = vm.log.toJS(vm.global, bun.default_allocator, "Error in worker"); | |||
| const str = err.toBunString(vm.global); | |||
| const str = err.toBunString(vm.global) catch bun.String.static("(threw exception creating message)"); | |||
There was a problem hiding this comment.
should this exception be cleared?
|
|
||
| var preloads = std.ArrayList([]const u8).initCapacity(bun.default_allocator, preload_modules_len) catch bun.outOfMemory(); | ||
| for (preload_modules) |module| { | ||
| const utf8_slice = module.toUTF8(bun.default_allocator); | ||
| defer utf8_slice.deinit(); | ||
| if (resolveEntryPointSpecifier(parent, utf8_slice.slice(), error_message, &temp_log)) |preload| { | ||
| if (resolveEntryPointSpecifier(parent, utf8_slice.slice(), error_message, &temp_log) catch return null) |preload| { |
There was a problem hiding this comment.
caller cannot differentiate error.OutOfMemory and error.JSError
| const path = resolveEntryPointSpecifier(parent, spec_slice.slice(), error_message, &temp_log) orelse { | ||
| return null; | ||
| }; | ||
| const path = (resolveEntryPointSpecifier(parent, spec_slice.slice(), error_message, &temp_log) catch return null) orelse return null; | ||
|
|
||
| var preloads = std.ArrayList([]const u8).initCapacity(bun.default_allocator, preload_modules_len) catch bun.outOfMemory(); |
There was a problem hiding this comment.
memory leak if line 206 returns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
progress towards #15141