-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bustDirCache on FileSystemRouter.reload & fix of dir_cache keys in windows #15091
Conversation
…ges in routes directory to take effect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice. at a glance this looks reasonable, but you should add a test case to cover changing directories
Can’t we bump the version number and then we don’t need to eagerly call bustDirCache? |
@Electroid it seems it didnt worked, since CI still said no changed files |
The key generation for dir_caches had a bug on windows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will run tests but one nitpick
What does this PR do?
When the structure of the routes directory for the FileSystemRouter changes, the reload function cant load it, because readDirInfo is cached. So I changed the code to recursively bust the dirCache.
How did you verify your code works?
I dont know how to write tests for this. Ive tested it locally.
Fixes #4522