Fixes #14918 #14921
Merged
Fixes #14918 #14921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ @Jarred-Sumner, your commit 1c7eb09 has 2 failures in test/js/node/test/parallel/child-process-exec-timeout-kill.test.js - 1 failing on 🍎 aarch64test/cli/hot/hot.test.ts - timeout on 🪟 x64 |
dylan-conway
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When creating a File from another File and then appending it to FormData, once that FormData gets GC’d it can potentially crash because the file name’s string’s reference count was not incremented when the File object was duplicated (because this code was originally for Blob, which didn’t have a file name)
Fixes #14918
How did you verify your code works?
There is a test