Redact secrets in bunfig.toml and npmrc logs
#14919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ @dylan-conway, your commit b8ca2fc has 6 failures in test/js/bun/shell/leak.test.ts - 1 failing on 🪟 x64test/js/bun/spawn/spawn-stdin-destroy.test.ts - 1 failing on 🪟 x64test/js/bun/http/serve.test.ts - 1 failing on 🍎 x64test/js/bun/test/test-test.test.ts - 1 failing on 🪟 x64test/js/node/net/node-net.test.ts - 1 failing on 🪟 x64test/cli/install/registry/bun-install-registry.test.ts - 1 failing on 🍎 aarch64 |
nektro
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces secrets with
*when logging errors and warnings forbunfig.tomlandnpmrcfiles.Special keywords searched for: _auth, _authToken, email, _password, token. Additionally UUIDs,
npm_prefixed tokens, and passwords in urls are replaced.closes #14867
closes #14444
How did you verify your code works?
Added tests for keywords and edgecases