Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #14187 #14884

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Fix #14187 #14884

merged 3 commits into from
Oct 29, 2024

Conversation

pfgithub
Copy link
Contributor

What does this PR do?

Fixes #14187

  • Replace bun's on implementation with node's implementation

  • Add node's tests for once and on

  • Add listenerCount() support for EventTargets. Node does not support this.

  • Replaces eventTargetAgnosticAddListener and eventTargetAgnosticRemoveListener with node's implementation that throws the right errors.

  • Update validators.ts's implementation of validateObject to throw on null, like node's does when no options parameter is provided.

  • Removes fixed queue test because it tests nothing.

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)

  • Code changes

How did you verify your code works?

  • I included a test for the new code, or existing tests cover it
  • I ran my tests locally and they pass (bun-debug test test-file-name.test)

@robobun
Copy link

robobun commented Oct 29, 2024

@pfgithub, your commit 8437baf has some failures in #5388

@Jarred-Sumner Jarred-Sumner merged commit 698e87a into main Oct 29, 2024
35 of 40 checks passed
@Jarred-Sumner Jarred-Sumner deleted the pfg/issue-14187 branch October 29, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak in on method from node:events
3 participants