bundler: Add --ignore-dce-annotations, and other DCE annotation related stuff
#12808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
paperclover
changed the title
--ignore-annotations, and other DCE annotation related stuff--ignore-dce-annotations, and other DCE annotation related stuff
Jarred-Sumner
requested changes
Jul 29, 2024
|
❌ @Jarred-Sumner, your commit b6b7766 has 21 failures in |
| @@ -544,7 +546,7 @@ pub const Options = struct { | |||
|
|
|||
| module_type: options.OutputFormat = .preserve, | |||
|
|
|||
| /// Used for cross-module inlining of import items when bundling | |||
| // /// Used for cross-module inlining of import items when bundling | |||
There was a problem hiding this comment.
Suggested change
| // /// Used for cross-module inlining of import items when bundling | |
| // Used for cross-module inlining of import items when bundling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
--ignore-dce-annotations, one step close to esbuild compatibility/* @__PURE */when not minifying whitespace. This is helpful if the output is consumed by another build tool.--emit-dce-annotationsto allow emitting annotations even when minifying.The second and third cases are things I specifically want for future changes to our node_fallbacks code. Right now we use esbuild for that, when we really should use Bun. An issue with using Bun is that DCE comments will get stripped, resulting in no tree shaking when Bun re-bundles them.
Esbuild also has this issue since we are passing --minify to compress the size. In the future, we can pass
--minifyand--emit-annotationsand get both.