Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bun-types overwrites base react elements #5891

Open
chalabi2 opened this issue Sep 22, 2023 · 4 comments
Open

bun-types overwrites base react elements #5891

chalabi2 opened this issue Sep 22, 2023 · 4 comments
Labels
bug Something isn't working typescript Something for TypeScript

Comments

@chalabi2
Copy link

What version of Bun is running?

1.0.2+37edd5a6e389265738e89265bcbdf2999cb81a49

What platform is your computer?

Darwin 22.4.0 arm64 arm

What steps can reproduce the bug?

  const handleSearchChange = (event: React.ChangeEvent<HTMLInputElement>) => {
    setSearchTerm(event.target.value.toLowerCase());
  };
  

Above is a basic handler for setting a constant to be the user input.

with bun-types installed it errors with, value does not exist on event

It works fine just throws a type error

What is the expected behavior?

It should have no error

What do you see instead?

It works fine just doesnt build without error

Additional information

No response

@chalabi2 chalabi2 added the bug Something isn't working label Sep 22, 2023
chalabi2 added a commit to chalabi2/quicksilver-app-v2 that referenced this issue Sep 22, 2023
@mstuercke
Copy link

Still happens in 1.0.6

@jjhiggz
Copy link

jjhiggz commented Oct 26, 2023

Having the same issue! For context, it's happening with me in an an app that doesn't need "bun-types" for its runtime but references "bun-types" indirectly through importing the type schema from my backend in an edenTreaty like so:

import { edenTreaty } from "@elysiajs/eden/treaty";
import type { ElysiaApp } from "backend"; // this line is what breaks everything

export const treaty = edenTreaty<ElysiaApp>("http://localhost:3001");

@Electroid Electroid added the typescript Something for TypeScript label Oct 30, 2023
@The-Code-Monkey
Copy link

@chalabi2 did you find a fix for this

@murderteeth
Copy link

I started having this problem when I started using bun for testing and had to configure tsconfig with "types": ["bun-types"].

This is how I got around the problem:

  • remove "types": ["bun-types"] from tsconfig
  • bun remove bun-types
  • bun add -D @types/jest

This way I'm still using the bun test runner, but my project can still build because the bun test types are subset of jest.

faddat added a commit to quicksilver-zone/quicksilver that referenced this issue Dec 19, 2023
* Initial commit (via bun create)

* bun-qs

* update readme for bun

* remove broken query call

* add export

* add deploy work flow

* update deploy.yml

* update deploy.yml

* syntax error

* add homepage

* fix module exports

* fix module export path  for gh pages

* change image paths for gh pages

* center return button

* organize modal structure

* fix balance
prepare qs queries

* add bun server for potential backend
add initial bun test

* add

* remove yarn lock

* *change network select menu *fix nav menu selection color change

* * Follow [issue](oven-sh/bun#5891)

* remove useless ignore

* *swap to testnet
*begin steaking tx

* rough swap to grpcGatewayClient

* add state management for intent tx

* deploy test

* deployment test

* ignore errors

* ts ignore

* add apr fetch

* - add zone query
- add data points

* - staking fixes

* fix inputs

* working staking tx

* fix intent memo

* - fix input number handling

* finish stakingTx

* - custom weight updates
- unstaking data points

* - finish unstaking tx
- fix broken step 4 on staking modal
- fix intent weight state managment

* - start mobile
- fix app layout
- add side header socials

* - makeshit usechains
- wallet connect button style

* - staking ui updates

* - add mobile menu

* - gov revert
- pre merge

* update todo

* update actions branch

* finish gov reversion

* - loading state ideas

* add rough assets page

* finish assets mock

* - asset page components
- asset page queries

* portfolio box queries

* fix portfolio percentages

* portfolio stuff

* move into folder that is now empty in qs repo

* add chalabi's work with the commit history

---------

Co-authored-by: Joseph Chalabi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working typescript Something for TypeScript
Projects
None yet
Development

No branches or pull requests

6 participants