Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix panic shadowing #67

Merged
merged 5 commits into from
Jun 3, 2024
Merged

fix panic shadowing #67

merged 5 commits into from
Jun 3, 2024

Conversation

ovechkin-dm
Copy link
Owner

No description provided.

@ovechkin-dm ovechkin-dm linked an issue May 27, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 87.71%. Comparing base (b8dcdb0) to head (c816f0b).

Files Patch % Lines
registry/reporter.go 80.76% 5 Missing ⚠️
tests/common/common.go 75.00% 2 Missing ⚠️
registry/registry.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   87.59%   87.71%   +0.11%     
==========================================
  Files          14       14              
  Lines        1024     1058      +34     
==========================================
+ Hits          897      928      +31     
- Misses        103      107       +4     
+ Partials       24       23       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emilien-puget
Copy link
Contributor

Is it possible to add tests for this?

@ovechkin-dm
Copy link
Owner Author

Added the test. Although it is hard to verify full behavior with panic, so I only checked that Errorf is called instead of Fatalf for postponed verification

@ovechkin-dm ovechkin-dm merged commit 8cefaf1 into main Jun 3, 2024
9 checks passed
@ovechkin-dm ovechkin-dm deleted the 63-hidden-panic branch June 10, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic is hidden if there are any failed expectations
3 participants