This repository has been archived by the owner on Apr 25, 2019. It is now read-only.
Fixes two issues #161 and #162 #163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anyone able to help with this test failure? It's not clear what the string test is expecting. |
|
I'll have a look at the test failure, it's unrelated to this PR. I'd prefer an extension point rather than a hard-coded blankie config in there. |
|
@Marsup Are you referring to an extension point such as onPreStart? I'm not able to change or define the route information on that server event. |
|
I mean be able to provide those options as part of the initialization of the plugin, this way it would support more than this specific use case. |
|
Do you still want to push this ? |
|
Nah, it doesn't fit the project expectations |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix hyperlink to hapi guidelines for contributing (Update guidelines for contributing #161)
Blankie support whitelists CDN fonts, styles, and scripts (Add Content Security Policy using blankie #162)
Tested on Windows (no additional tests fail)
Optionally compatible with blankie closes blankie issue (Hapijs/lout and blankie thrown an exception nlf/blankie#15)