WIP: Started rolling mean for lineage and total count 6 days before #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st detection I didn't test these changes, they are done based on my understanding of what the code does,. At least the idea should work. May need debugging.
|
Hey, thank you for the pull request. Looks like this should work but I will test and review tonight. |
|
Let's hope it does. It would be cool! But there may be edge cases...
Would be cool if there was a test suite for the API to help refactoring and
continuous integration. Maybe something else to think about.
…On Fri, May 7, 2021 at 12:30 AM Karthik ***@***.***> wrote:
Hey, thank you for the pull request. Looks like this should work but I
will test and review tonight.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#12 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF77AQI655IDUW3EULETBQ3TMMJ7ZANCNFSM44IANGVQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes outbreak-info/outbreak.info#352
I didn't test these changes, they are done based on my understanding of what the code does,. At least the idea should work, starting the rolling mean 6 days earlier. May need debugging.