Fix incorrect default sensors transform for beam and IMU #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrsolichin
changed the title
Samahu
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
@wrsolichin You are absolutely correct the values were somehow swapped 🫢
I will run couple internal checks and have this merged soon.
Thanks for the fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default values of the IMU to sensor transform and beam to LiDAR transform is incorrect, they are swapped.
Related Issues & PRs
Summary of Changes
The values of the IMU to sensor transform and beam to LiDAR transform is swapped to the correct transform.
Validation