Merge pull request #79 from ourzora/matt/zora-legacy-media-fixes

Zora legacy media fixes & doc updates
ourzora · Aug 8, 2023 · 7aff95d · 7aff95d
2 parents b25fc75 + 3bdb1f9
commit 7aff95d
Show file tree

Hide file tree

Showing 7 changed files with 378 additions and 448 deletions.
diff --git a/docs/changelog.md b/docs/changelog.md
@@ -2,7 +2,8 @@
 
 ## v0.1.5
 
-- bump web3 dependency to latest version
+- fix zora legacy media parsing
+- update release docs
 
 ## v0.1.4
 

diff --git a/docs/contributing/publish_release.md b/docs/contributing/publish_release.md
@@ -76,7 +76,7 @@ Make sure your versions are appended with `v`. This will be the version publishe
     All releases must be made with a GPG signed tag. Don't create a tag without signing it.
 
 ```bash
-git tag -asm "v0.0.2"
+git tag -sm "v0.0.2"
 git push origin v0.0.2
 ```
 

diff --git a/docs/index.md b/docs/index.md
@@ -1,6 +1,6 @@
 # Getting Started
 
-Documentation for version: **v0.1.4**
+Documentation for version: **v0.1.5**
 
 ## Overview
 

diff --git a/offchain/metadata/parsers/collection/collection_parser.py b/offchain/metadata/parsers/collection/collection_parser.py
@@ -40,4 +40,4 @@ def should_parse_token(self, token: Token, *args, **kwargs) -> bool:
         Returns:
             bool: whether or not the collection parser handles this token.
         """
-        return token.collection_address in [address.lower() for address in self._COLLECTION_ADDRESSES]
+        return token.collection_address.lower() in [address.lower() for address in self._COLLECTION_ADDRESSES]
diff --git a/offchain/metadata/parsers/collection/zora.py b/offchain/metadata/parsers/collection/zora.py
@@ -69,7 +69,7 @@ def get_content_details(self, uri: str) -> Optional[MediaDetails]:
         return None
 
     def parse_metadata(self, token: Token, raw_data: Optional[dict], *args, **kwargs) -> Optional[Metadata]:
-        if token.uri is None or raw_data is None:
+        if token.uri is None or raw_data is None or not isinstance(raw_data, dict):
             token.uri = self.get_uri(token.token_id)
             raw_data = self.fetcher.fetch_content(token.uri)
 

diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -12,7 +12,7 @@ requests = "^2.28.1"
 pydantic = "^1.9.2"
 python-json-logger = "^2.0.4"
 urllib3 = "^1.26.11"
-web3 = ">=5.30.0 <=6.7.0"
+web3 = "^5.30.0"
 tenacity = "^8.0.1"
 
 [tool.poetry.dev-dependencies]