fix: add firebase service account key to env variable #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, a new developer starting server would get an error message saying private key is missing. Installed dotenv to handle environment variables in the code. Updated README with instructions on how to get a private key from firebase and how to add it to the local env file.
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
evan-desu
requested review from
theyokohamalife,
ermish and
jbcden
as code owners
theyokohamalife
approved these changes
Aug 5, 2023
|
@all-contributors please add @evan-desu for code |
|
We had trouble processing your request. Please try again later. |
ermish
pushed a commit
that referenced
this pull request
Aug 28, 2023
* fix: add firebase service account key to env variable Prior to this change, a new developer starting server would get an error message saying private key is missing. Installed dotenv to handle environment variables in the code. Updated README with instructions on how to get a private key from firebase and how to add it to the local env file. * docs: Add instructions for setting up Firebase Service Account
theyokohamalife
added a commit
that referenced
this pull request
Aug 29, 2023
* progress * fix(deps): update dependency firebase-admin to v11.6.0 (#182) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * got build and queries working again! (#181) * fix(deps): update dependency csv-parse to v5.3.8 (#183) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Philip Ermish <[email protected]> * chore(deps): update yarn to v3.5.1 (#190) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Philip Ermish <[email protected]> * fix(deps): update dependency @apollo/server to v4.7.0 (#185) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency eslint to v8.40.0 (#179) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: LaShawn Toyoda <[email protected]> * chore(deps): update dependency firebase-tools to v11.28.0 (#184) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: LaShawn Toyoda <[email protected]> * fix(deps): update dependency firebase to v9.22.0 (#186) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: LaShawn Toyoda <[email protected]> * chore(deps): update typescript-eslint monorepo to v5.62.0 (#187) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @types/chai to v4.3.5 (#188) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency all-contributors-cli to v6.26.1 (#189) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency csv-parse to v5.4.0 (#193) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: add firebase service account key to env variable (#204) * fix: add firebase service account key to env variable Prior to this change, a new developer starting server would get an error message saying private key is missing. Installed dotenv to handle environment variables in the code. Updated README with instructions on how to get a private key from firebase and how to add it to the local env file. * docs: Add instructions for setting up Firebase Service Account * chore(deps): update graphqlcodegenerator monorepo to v4 (#194) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency node to v18.17.0 (#197) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency firebase to v10 (#210) * chore(deps): update dependency firebase-tools to v12 (#192) * feat: add Submission type and input (#208) The reason for this change is to allow users to submit incomplete information to be reviewed by moderators prior to being searchable on the website * feat: add mutations for addFacility and addHealthcareProfessional (#203) * feat: implement mutation for addFacility * feat: implement mutation for addHealthcareProfessional * refactor: fix healthcareProfessionalService types * refactor: fix types and move function * chore(deps): update reviewdog/action-eslint action to v1.19.2 (#205) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Remove codeowners until the repo goes public (#228) * chore: set renovate confidence to high (#215) Co-authored-by: Philip Ermish <[email protected]> * Refactor FacilityService and HealthcareProfessionalService (#223) * chore: update healthcareProfessional service * feat: add new Facility with HealthcareProfessional Ids * refactor: clean up imports * feat: add the isDeleted field to Facility and HealthcareProfessional * chore(deps): update node.js to v18.17.1 (#216) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: LaShawn Toyoda <[email protected]> * chore(deps): update dependency @graphql-codegen/cli to v5 (#217) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: LaShawn Toyoda <[email protected]> * 👥 Add @evan-desu as a contributor (#231) * feat: add a submissionService file and Submission type definitions (#213) Previously there were no service functions to allow users to get, add, or update submissions. There are now functions to perform these tasks. There is now also a Submission type alias in TypeDefs/dbschema.ts * feat: add a submissionService file and Submission type definitions (#218) * feat: implement end-to-end testing with Jest and Supertest (#227) * feat: implement end-to-end testing with Jest and Supertest Prior to this commit the tests that were in place were legacy tests for when our tech stack included Prisma and Postgres. Now that we're using Firestore they're no longer needed. * feat: add GitHub action to run tests * feat: add mock firebase config for jest Co-authored-by: Anissa Chadouli [email protected] * docs: update testing instructions * test: happy path is successful * refactor: separate env variables for dev and prod Co-authored-by: Philip Ermish <[email protected]> * chore: fix docker in github actions Co-authored-by: Philip Ermish <[email protected]> * chore: fix docker in github actions Co-authored-by: Philip Ermish <[email protected]> * chore: fix yarn path Co-authored-by: Philip Ermish <[email protected]> * chore: check in dev and prod env Co-authored-by: Philip Ermish <[email protected]> * Update README.md * Update __tests__/server.test.ts * Update src/index.ts --------- Co-authored-by: Philip Ermish <[email protected]> * upgraded to node 20 and relevant packages * got build working! * merge fixes. build works again * commenting out in progress workflows --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: LaShawn Toyoda <[email protected]> Co-authored-by: Evan Peterson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, a new developer starting server would get an error message saying private key is missing. Installed
dotenvto handle environment variables in the code. UpdatedREADMEwith instructions on how to get a private key from firebase and how to add it to the localenvfile.Resolves #198
What changed
dotenv packageto load environment variables intoprocess.env.firebaseServiceAccountKey.jsontogitignoreto keepprivate_keyprivate.database.ts.credentialsvariable to point tofirebaseServiceAccountKey.json.READMEfor setting up Firebase Service Account.Testing instructions
yarn installto update dependencies.firebaseServiceAccountKey.json..envby adding the lineSERVICE_ACCOUNT_PATH=./firebaseServiceAccountKey.json.yarn devand confirm server is working.