fix: moved logic to set date to prevent user from accidentally passin…

…g it in
ourjapanlife · Sep 11, 2023 · c54e42d · c54e42d
1 parent 60ec5c3
commit c54e42d
Showing 1 changed file with 11 additions and 7 deletions.
diff --git a/src/services/submissionService.ts b/src/services/submissionService.ts
@@ -100,31 +100,35 @@ export async function getSubmissions(filters: dbSchema.SubmissionSearchFilters =
     }
 }
 
-function convertToDbSubmission(submission: gqlType.Submission): 
+function convertToDbSubmission(submission: gqlType.SubmissionInput): 
     dbSchema.Submission {
     return {
         ...submission,
+        id: '',
+        isUnderReview: true,
+        isApproved: false,
+        isRejected: false,
+        createdDate: new Date().toISOString(),
+        updatedDate: new Date().toISOString(),
         spokenLanguages: submission.spokenLanguages
             .filter(lang => lang !== null) as dbSchema.SpokenLanguage[]
     }
 }
 
-export const addSubmission = async (submission: gqlType.Submission): 
+export const addSubmission = async (submissionInput: gqlType.SubmissionInput): 
     Promise<dbSchema.Submission> => {
     try {
-        const dbSubmission = convertToDbSubmission(submission)
+        const dbSubmission = convertToDbSubmission(submissionInput)
 
         const submissionRef = dbInstance.collection('submissions')
 
         const docRef = await submissionRef.add(dbSubmission)
 
-        const currentDate = new Date().toISOString()
-
         const newSubmission: dbSchema.Submission = {
             ...dbSubmission,
             id: docRef.id,
-            createdDate: currentDate,
-            updatedDate: currentDate
+            createdDate: new Date().toISOString(),
+            updatedDate: new Date().toISOString()
         }
 
         return newSubmission