fix: fix decompress issue with rar files which include CJK filenames in it #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttys3
changed the title
|
Nice PR. Yeah, we need to wait for their release otherwise this can block a new version of Ouch. |
|
OK, I changed the PR to WIP status |
ttys3
force-pushed
the
fix/rar-decompress
branch
from
f4d42be to
9c70ebf
Compare
…nclude CJK filenames in it
ttys3
force-pushed
the
fix/rar-decompress
branch
from
9c70ebf to
8491a88
Compare
marcospb19
approved these changes
Dec 6, 2024
|
ty, I see you created another PRs, sorry, I might take some time to take a proper look at them, busy weeks, but I'll catch up when I can |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update unrar crate to fix decompress issue with rar files which include CJK filenames in it
prev we fixed the CJK filename issue for the archive filename itself
this time, it is the filename in the archive.
that's to say, if
foo.rarcontains❤️.txtin it, the decompression will failwe need wait unrar crate to release a new version