-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature-gate RAR support #566
Conversation
I'd prefer if it was opt-out, here's how I think about it:
Instead of:
I think the first one seems more natural, plus, Ouch is licensed under MIT so people should be aware that non-FOSS code might be in it, at least if that's a dealbreaker for them. |
Yeah that's fine. I'm happy to respect project owners' decision on this. |
Rebased. |
Hi! Is it ready for review? PR is set as draft. |
Not yet. Still have to modify CI (which could really use some cleaning up). I'll also try to reenable tests on Windows and see what's wrong there. Will make some time for this tomorrow. |
Blocking on #578. |
Yep sorry for that delay, I'll answer you as soon as feasible. |
Rebased on main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, I gave it a deep review but found no flaws.
I also appreciate your help with the CI and with how to use insta
with conditional compilation, I never thought of changing the test name (I didn't know it was possible, hard to find it in the docs).
See #565.
This PR does not fully close the issue; the ideal solution would be to use a FOSS library for unrar support. But that can wait.
Unresolved/todo
unrar
feature be opt-in or opt-out?unrar
feature enabled and disabled).