Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly declare feature flags use_zlib & use_zstd_thin #564

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Explicitly declare feature flags use_zlib & use_zstd_thin #564

merged 2 commits into from
Dec 5, 2023

Conversation

cyqsimon
Copy link
Contributor

@cyqsimon cyqsimon commented Dec 3, 2023

I've got another PR queued up after this one relating to feature-gating unrar. So I thought I'd tidy things up first.

@cyqsimon cyqsimon changed the title Tidy up features Explicitly declare feature flags use_zlib & use_zstd_thin Dec 3, 2023
marcospb19
marcospb19 approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@marcospb19 marcospb19 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you!

@marcospb19 marcospb19 requested a review from figsoda December 5, 2023 00:30
@marcospb19 marcospb19 merged commit e09d82e into ouch-org:main Dec 5, 2023
12 checks passed
@p-linnane p-linnane mentioned this pull request Dec 6, 2023
Merged
@cyqsimon cyqsimon deleted the feature-cleanup branch December 9, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcospb19 marcospb19 marcospb19 approved these changes

@figsoda figsoda Awaiting requested review from figsoda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyqsimon @marcospb19