-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] Smart decompress into a directory #195
Conversation
Do you have idea why it's failing on |
I added an XXX note where the problem is Rename cant happen between different mount points (like /tmp and /) Thats why in proptest the tempdir should be created in /tmp but somehow proptest still takes the tempdir_in(".") path and create it in the wrong place Im not sure whats the real issue I thought proptest should invoke the code under cfg test but it isnt, maybe its a bug |
Thats whats hapenning on linux, Im guessing its the same issue in windows |
Maybe a more correct approach is to create the temp directory in the parent folder of the output file instead of hardcoding to "." I think that would make it work im all cases |
Got it, so, I did not had the time to review this properly yet, |
That's a good thing! |
I'm not sure about the windows test yet Also there are still some edge cases not handled |
Superseded by #209 |
fix #151
This a bit complex and I managed to remove directories unintentionally a couple of times when writing it, so the maintainers needs to judge if this complexity is worth it.