-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rewrite tests #163
rewrite tests #163
Conversation
This comment has been minimized.
This comment has been minimized.
Will give a proper review in a couple days. Got a bit busy again. |
resolved merge conflicts |
I really like this addition, but the scary part for me, as a non-initiated proptest user, is if we will be able to interpret the tests and be sure that they are doing their job along time. Also, we probably should write something about it on I will keep looking into it so as to help understand how we should work with proptest, but you can help guide us on how to make this workflow more understandable that would be neat (: p.s.: I will add that I believe this crate and philosophy of testing is amazing and I would find it really fun and useful to get some experience with it, even if it requires some work |
Btw, have you understood how these changes fixed #50 ? It would be nice to know what we were doing wrong, for future reference |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool :D
I think that the assert_cmd
approach is very interesting but it could bite us in the future if we ever decide to add code coverage metrics, I guess
rewrite most tests with proptest, tests single file {,de}compression and directory {,de}compression
Also found an issue with chaining lz4 compressions:
tar.lz4.lz4
files are not being compressed correctly, so it is ignored for nowI don't think file permissions are working on windows and for zip files, so I disabled checking them in these situations
Closes #30
Closes #31
Closes #50