-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infer file extension when decompressing #154
Conversation
Thanks for your first contribution to |
I updated the pr, I can squash the commits later when the review is done. |
Sorry for my late review.
I left one conversation unresolved for that warning, before you squash it. |
I added the info! |
I think I can squash that for you. |
Adding copyright notice from "infer" crate
And reworked detection for other formats as well
I found a small bug at the zip detection and fixed it, unfortunately git history says I commited and you authored, I don't understand why it's not the opposite, but anyways, thanks for your contribution! This is a great addition. |
Thanks as well! That function is copied from infer, so I'll let the author know. |
For reference, you sent the https://en.wikipedia.org/wiki/List_of_file_signatures link, there, we have the line: So it's about .zip, here is the first column:
So, it should be Which mixes things up, you could have
|
(There is also a chance that our source contains the wrong information and the original code was right all along. Pinging @bojand here too) |
#142
#145