Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the format with Github Action #126

Merged
merged 3 commits into from
Oct 27, 2021
Merged

Check the format with Github Action #126

merged 3 commits into from
Oct 27, 2021

Conversation

boozec
Copy link
Contributor

@boozec boozec commented Oct 25, 2021

As you can read at this review [1] a format checking is something good to
avoid branch conflitcs etc.

Use a job to check the format of the sourcecode with cargo fmt
command. The new step does not change any code, but returns an error
when check does not pass with 0 issues.

[1] #125 (review)

Use a job to check the format of the sourcecode with `cargo fmt`
command. The new step does not change any code, but returns an error
when `check` does not pass with 0 issues.
@GabrielSimonetto GabrielSimonetto self-requested a review October 27, 2021 00:12
@GabrielSimonetto GabrielSimonetto self-requested a review October 27, 2021 03:20
Copy link
Collaborator

@GabrielSimonetto GabrielSimonetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you for your contribution.

@GabrielSimonetto GabrielSimonetto merged commit 01b6dc8 into ouch-org:master Oct 27, 2021
@marcospb19 marcospb19 added the hacktoberfest-accepted Tag PR as accepted for the hacktoberfest event label Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Tag PR as accepted for the hacktoberfest event
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants