Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change output flag to dir flag #118

Merged
merged 1 commit into from
Oct 31, 2021
Merged

Conversation

khubo
Copy link
Contributor

@khubo khubo commented Oct 20, 2021

this changes the -o/--output to -d/--dir in decompress Command.

fixes #115

@marcospb19
Copy link
Member

Thanks for your contribution!

I think this will get merged, but I'll need to wait a couple days beforehand, to see what other people thinking about that issue.

Expect a delay of at maximum 2 days.

@SpyrosRoum
Copy link
Contributor

Even if this gets merged I think it might be best to wait for #108 first

@marcospb19
Copy link
Member

marcospb19 commented Oct 21, 2021

@GabrielSimonetto pointed out that this would not let us have --output - anymore if we want to use STDOUT. But we have other possible solutions for that problem.

In last instance, /dev/stdout and /dev/stdin with --format can save us.

@marcospb19 marcospb19 merged commit 4e731f8 into ouch-org:master Oct 31, 2021
@marcospb19 marcospb19 added the hacktoberfest-accepted Tag PR as accepted for the hacktoberfest event label Oct 31, 2021
@marcospb19
Copy link
Member

Thanks for the contribution and sorry for the late merge, I took some time to rest recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Tag PR as accepted for the hacktoberfest event
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing --output to --dir
3 participants