Fix error treatment calling todo!() and crashing in non-exhaustive match.

[marcospb19]

No description provided.

[GabrielSimonetto]

This issue is regarding the impl fmt::Display for Error on error.rs

            Error::OofError(err) => FinalError::with_title(err),
            Error::IoError { reason } => FinalError::with_title(reason),
           ...
            _err => {
                todo!();
            }

TODO display messages:

• - UnknownExtensionError(String)
• - MissingExtensionError(PathBuf)
• - IoError { reason: String }
• - FileNotFound(PathBuf)
• - AlreadyExists
• - InvalidZipArchive(&'static str)
• - PermissionDenied
• - UnsupportedZipArchive(&'static str)
• - InternalError
• - OofError(oof::OofError)
• - CompressingRootFolder
• - MissingArgumentsForCompression
• - CompressionTypo
• - WalkdirError { reason: String }

It would be neat to tackle this as soon as possible because dropping the wildcard match forces us to add the error messages as soon as a new error enum is created, and as is, the pile could just grow forever unattended 🍍

[marcospb19]

Wow, nice checklist.

This is a priority, however, this issue is blocked by #56, that one needs to be resolved first.

That's because a lot of the work necessary to solve this issue would have to be discarded and remade after #56, because fs-err will change our error messages.

[GabrielSimonetto]

#56 is solved so this is not blocked anymore d:

[GabrielSimonetto]

I will paste here a way to trigger one of the untreated errors, since it might be useful to someone, the error in particular is the NotFound

impl From<std::io::Error> for Error {
    fn from(err: std::io::Error) -> Self {
        match err.kind() {
            std::io::ErrorKind::NotFound => todo!(),

Currently this error just panics:

thread 'main' panicked at 'not yet implemented', src/error.rs:161:45
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

The way to trigger it is to delete the file you are trying to decompress after the program has checked that it exists, you can do that inserting a sleep after the command check:

        Subcommand::Decompress { files, output: output_folder } => {
            std::thread::sleep(std::time::Duration::from_secs(10));

Then, while it sleeps you remove the zip that you are working with