AO3-5578 Avoid unnecessary DB writes when copying icons #5017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjaustin
added
the
Priority: High - Broken on Test
Bilka2
approved these changes
Jan 8, 2025
slavalamp
pushed a commit
to slavalamp/otwarchive
that referenced
this pull request
Jan 12, 2025
* AO3-5578 Avoid unnecessary DB writes when copying icons * Rubocop :fistshake:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Issue
https://otwarchive.atlassian.net/browse/AO3-5578
Purpose
Avoid unnecessary DB writes by turning off auto timestamp updates (
touch) for the model whose icons are being copied. @sarken discovered that the previous version of the task was updating those, which will definitely be unhappy for thepseudstable in prod