Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6792: use permitted_attributes instead #5002

Conversation

Cesium-Ice
Copy link
Contributor

@Cesium-Ice Cesium-Ice commented Dec 23, 2024

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-6792

Purpose

What does this PR do?

Testing Instructions

How can the Archive's QA team verify that this is working as you intended?

If you have a Jira account with access, please update or comment on the issue
with any new or missing testing instructions instead.

References

Are there other relevant issues/pull requests/mailing list discussions?

Credit

What name and pronouns should we use to credit you in the Archive of Our Own's Release Notes?

If you have a Jira account, please include the same name in the "Full name"
field on your Jira profile, so we can assign you the issues you're working on.

Please note that if you do not fill in this section, we will use your GitHub account name and
they/them pronouns.

@Cesium-Ice Cesium-Ice marked this pull request as ready for review December 23, 2024 10:44
@brianjaustin brianjaustin merged commit 74655f9 into otwcode:master Dec 23, 2024
29 checks passed
Copy link

sentry-io bot commented Dec 23, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ActiveRecord::ValueTooLong: Mysql2::Error: Data too long for column 'short' at row 1 LanguagesController#update View Issue

Did you find this useful? React with a 👍 or 👎

@brianjaustin
Copy link
Member

Nope, I found that while I was testing but I think it's an existing bug. I'll see if I can dig something up in Jira

@Cesium-Ice Cesium-Ice deleted the AO3-6792-admins-with-the-support-and-policy-and-abuse-roles-should-be-able-to-edit-languages-v3 branch December 23, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants