Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6866 Add no_resets and protected_user user roles to test fixtures #4998

Conversation

Bilka2
Copy link
Contributor

@Bilka2 Bilka2 commented Dec 20, 2024

Issue

https://otwarchive.atlassian.net/browse/AO3-6866

Purpose

Make the role setup for new local dev environments and tests match production.

Testing Instructions

Automated tests should pass. I also recreated my local dev database with ./script/reset_database.sh and confirmed that the roles are created.

Credit

Bilka

@github-actions github-actions bot added Scope: Tests Only Only changes automated tests or test configuration Awaiting Review labels Dec 20, 2024
Copy link
Collaborator

@sarken sarken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The additions are good! Would you also want to take out the extra translator roles (role_00004 and role_00005) and set the authorizable_type and authorizable_id on the remaining one to empty?

You might have to update test/fixtures/user_roles.yml so users are only assigned the remaining translator role.

@sarken sarken merged commit 6caa157 into otwcode:master Dec 22, 2024
29 checks passed
@Bilka2 Bilka2 deleted the AO3-6866-add-no-resets-and-protected-user-user-roles-to-test-fixtures branch December 22, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Reviewed: Ready to Merge Scope: Tests Only Only changes automated tests or test configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants