Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6792: fix logic to account for the fact that language_params can be blank #4988

Conversation

Cesium-Ice
Copy link
Contributor

@Cesium-Ice Cesium-Ice commented Dec 13, 2024

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-6792

Purpose

What does this PR do?

Fix bug that QA found

Testing Instructions

How can the Archive's QA team verify that this is working as you intended?

If you have a Jira account with access, please update or comment on the issue
with any new or missing testing instructions instead.

References

Are there other relevant issues/pull requests/mailing list discussions?

Credit

What name and pronouns should we use to credit you in the Archive of Our Own's Release Notes?

If you have a Jira account, please include the same name in the "Full name"
field on your Jira profile, so we can assign you the issues you're working on.

Please note that if you do not fill in this section, we will use your GitHub account name and
they/them pronouns.

@Cesium-Ice Cesium-Ice marked this pull request as ready for review December 13, 2024 21:14
@sarken sarken added the Priority: High - Broken on Test Merge immediately after approval label Dec 14, 2024
Copy link
Contributor

@Bilka2 Bilka2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, however could you update the two support/abuse related tests in features/admins/admin_languages.feature to use the support/policy_and_abuse admin roles (instead of translation) so that we test this case?

Copy link
Contributor

@Bilka2 Bilka2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sarken sarken merged commit 1375d27 into otwcode:master Dec 15, 2024
28 of 29 checks passed
@Cesium-Ice Cesium-Ice deleted the AO3-6792-admins-with-the-support-and-policy-and-abuse-roles-should-be-able-to-edit-languages-v2 branch December 16, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants