AO3-6529 Prevent work imports from AO3 #4981
Open
+15
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilka2
commented
Dec 7, 2024
|
I had another look at this and I would really like to remove the link from the error in all cases. That would make it possible to move the code and error message into StoryParser, which would automatically handle multiple URLs. |
|
I think that sounds reasonable, @sarken any concerns changing that part of the Jira story? |
|
I do not personally care about the link, but I think this was someone else's pet issue, so I will ask around! |
|
It's PAC's issue and dropping the link is fine! |
brianjaustin
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-6529
Purpose
Adds an error when trying to import works from URLs that are in the permitted hosts.
References
PR Limit: 6 out of 5
Using reviewer bonus:
#4676
#4763
Credit
Bilka