Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6856 Make default language no longer editable #4979

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Cesium-Ice
Copy link
Contributor

@Cesium-Ice Cesium-Ice commented Dec 4, 2024

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-6856

Purpose

What does this PR do?

Testing Instructions

How can the Archive's QA team verify that this is working as you intended?

If you have a Jira account with access, please update or comment on the issue
with any new or missing testing instructions instead.

References

Are there other relevant issues/pull requests/mailing list discussions?

Credit

What name and pronouns should we use to credit you in the Archive of Our Own's Release Notes?

If you have a Jira account, please include the same name in the "Full name"
field on your Jira profile, so we can assign you the issues you're working on.

Please note that if you do not fill in this section, we will use your GitHub account name and
they/them pronouns.

@Cesium-Ice Cesium-Ice marked this pull request as ready for review December 4, 2024 22:09
Copy link
Contributor

@Bilka2 Bilka2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just a minor issue with the error message, so I'm already approving this.

config/locales/controllers/en.yml Outdated Show resolved Hide resolved
spec/controllers/languages_controller_spec.rb Outdated Show resolved Hide resolved
@brianjaustin brianjaustin changed the title AO3-6856: Make default language no longer editable AO3-6856 Make default language no longer editable Dec 6, 2024
Cesium-Ice and others added 3 commits December 7, 2024 03:42
…ite-edit-link-being-hidden' of github.com:Cesium-Ice/otwarchive into AO3-6856-edit-page-for-default-language-accessible-despite-edit-link-being-hidden
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants